v1.4.0: cleaned up some TODOs and FIXMEs

This commit is contained in:
Evan Debenham
2022-08-06 13:03:11 -04:00
parent ec310353a8
commit 64d1b93862
22 changed files with 11 additions and 107 deletions
@@ -130,7 +130,6 @@ public enum Music {
@Override
public void onCompletion(com.badlogic.gdx.audio.Music music) {
//we do this in a separate thread to avoid graphics hitching while the music is prepared
//FIXME this fixes graphics stutter but there's still some audio stutter, perhaps keep more than 1 player alive?
if (!DeviceCompat.isDesktop()) {
new Thread() {
@Override
@@ -139,7 +138,7 @@ public enum Music {
}
}.start();
} else {
//don't use a separate thread on desktop, causes errors and makes no performance difference(?)
//don't use a separate thread on desktop, causes errors and makes no performance difference
playNextTrack(music);
}
}
@@ -202,7 +201,6 @@ public enum Music {
}
}
//TODO do we need to dispose every player? Maybe just stop them and keep an LRU cache of 2 or 3?
public synchronized void stop() {
if (player != null) {
player.dispose();