From f80f547da42f59f03b107f32e85eaa6c800da887 Mon Sep 17 00:00:00 2001 From: Evan Debenham Date: Mon, 26 Sep 2022 16:58:42 -0400 Subject: [PATCH] v1.4.0: fixed transmutation theoretically creating duplicate artifacts --- .../items/scrolls/ScrollOfTransmutation.java | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/core/src/main/java/com/shatteredpixel/shatteredpixeldungeon/items/scrolls/ScrollOfTransmutation.java b/core/src/main/java/com/shatteredpixel/shatteredpixeldungeon/items/scrolls/ScrollOfTransmutation.java index aeee7a4d3..70b27b76c 100644 --- a/core/src/main/java/com/shatteredpixel/shatteredpixeldungeon/items/scrolls/ScrollOfTransmutation.java +++ b/core/src/main/java/com/shatteredpixel/shatteredpixeldungeon/items/scrolls/ScrollOfTransmutation.java @@ -225,9 +225,12 @@ public class ScrollOfTransmutation extends InventoryScroll { } private static Artifact changeArtifact( Artifact a ) { - Artifact n = Generator.randomArtifact(); + Artifact n; + do { + n = Generator.randomArtifact(); + } while ( n != null && (Challenges.isItemBlocked(n) || n.getClass() == a.getClass())); - if (n != null && !Challenges.isItemBlocked(n)){ + if (n != null){ n.cursedKnown = a.cursedKnown; n.cursed = a.cursed; n.levelKnown = a.levelKnown;